Skip to content

Add 404 error handling for tech report#1122

Merged
max-ostapenko merged 4 commits intomainfrom
cold-crab
Sep 7, 2025
Merged

Add 404 error handling for tech report#1122
max-ostapenko merged 4 commits intomainfrom
cold-crab

Conversation

@max-ostapenko
Copy link
Copy Markdown
Contributor

@max-ostapenko max-ostapenko commented Sep 7, 2025 •
edited
Loading

@max-ostapenko
Refactor imports in routes.py and add 404 error handling for tech rep…
2bb3bd8 
…ort pages; update 404.html to simplify messaging
@tunetheweb
Copy link
Copy Markdown
Member

tunetheweb commented Sep 7, 2025

A you add | grep -v 404 to this line so it doesn’t try to run that in Lighthouse?

@max-ostapenko
Copy link
Copy Markdown
Contributor Author

max-ostapenko commented Sep 7, 2025

@tunetheweb which line?

@tunetheweb
Copy link
Copy Markdown
Member

tunetheweb commented Sep 7, 2025

Oops. Forgot to paste that!

httparchive.org/tools/scripts/set_lighthouse_urls.sh

Line 63 in f6c0158

CHANGED_FILES=$(git diff --name-only "main...${COMMIT_SHA}" --diff-filter=d templates config/reports.json | grep -v base.html | grep -v main.html | grep -v ejs | grep -v base_ | grep -v sitemap | grep -v error.html | grep -v techreport/components | grep -v techreport/templates | grep -v techreport/report | grep -v techreport/techreport)

tunetheweb
tunetheweb approved these changes Sep 7, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@max-ostapenko max-ostapenko merged commit a2847f8 into main Sep 7, 2025
11 checks passed
@max-ostapenko max-ostapenko deleted the cold-crab branch September 7, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tunetheweb tunetheweb tunetheweb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@max-ostapenko @tunetheweb